BUG: Series(index=[]) should have dtype=object #49574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
empty_series_with_index_dtype
branch
from
b75bfe9 to
cf220db
Compare
|
The failed check looks unrelated. |
mroeschke
added
Series
mroeschke
reviewed
Nov 8, 2022
| @@ -511,7 +511,10 @@ def _init_dict( | |||
| elif index is not None: | |||
| # fastpath for Series(data=None). Just use broadcasting a scalar | |||
| # instead of reindexing. | |||
| values = na_value_for_dtype(pandas_dtype(dtype), compat=False) | |||
| if len(index) or dtype is not None: | |||
There was a problem hiding this comment.
Do we know that index is list-like by the time we get here?
There was a problem hiding this comment.
Yes, partly from the type hints in this method and partly because of the index = ensure_index(index) part in the __init__ method.
|
Thanks for catching this. One question otherwise LGTM |
mroeschke
approved these changes
Nov 9, 2022
|
Thanks @topper-123 |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Nov 9, 2022
* BUG: Series(index=[]) should have dtype=object * parametrize tests * accept dtype * fix Co-authored-by: Terji Petersen <[email protected]>
codamuse
pushed a commit
to codamuse/pandas
that referenced
this pull request
Nov 12, 2022
* BUG: Series(index=[]) should have dtype=object * parametrize tests * accept dtype * fix Co-authored-by: Terji Petersen <[email protected]>
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* BUG: Series(index=[]) should have dtype=object * parametrize tests * accept dtype * fix Co-authored-by: Terji Petersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.No doc entry is needed, because this only fixes a corner case of #49342.