for gh-49508 changing Doc for DataFrame.astype #49556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added the series in input in the doc of DataFrame.astype
ramvikrams
changed the title
mroeschke
reviewed
Nov 7, 2022
pandas/core/generic.py
Outdated
| column label and dtype is a numpy.dtype or Python type to cast one | ||
| or more of the DataFrame's columns to column-specific types. | ||
| dtype : string, data type, Series or Mapping of column name -> data type | ||
| Use a data type like object (string, numpy.dtype, pandas.ExtensionDtype |
There was a problem hiding this comment.
Suggested change
| Use a data type like object (string, numpy.dtype, pandas.ExtensionDtype | |
| Use a string, numpy.dtype, pandas.ExtensionDtype |
mroeschke
reviewed
Nov 7, 2022
pandas/core/generic.py
Outdated
| or more of the DataFrame's columns to column-specific types. | ||
| dtype : string, data type, Series or Mapping of column name -> data type | ||
| Use a data type like object (string, numpy.dtype, pandas.ExtensionDtype | ||
| or Python type) to cast entire pandas object to the same type. Alternatively, |
There was a problem hiding this comment.
Suggested change
| or Python type) to cast entire pandas object to the same type. Alternatively, | |
| or Python type to cast entire pandas object to the same type. Alternatively, |
mroeschke
reviewed
Nov 7, 2022
pandas/core/generic.py
Outdated
| dtype : string, data type, Series or Mapping of column name -> data type | ||
| Use a data type like object (string, numpy.dtype, pandas.ExtensionDtype | ||
| or Python type) to cast entire pandas object to the same type. Alternatively, | ||
| use {col: dtype, ...}, where col is a column label and dtype is a |
There was a problem hiding this comment.
Suggested change
| use {col: dtype, ...}, where col is a column label and dtype is a | |
| use a mapping, e.g. {col: dtype, ...}, where col is a column label and dtype is a |
mroeschke
reviewed
Nov 7, 2022
Thanks I'll fix them up |
|
Done the changes sir |
|
Looks to be some validation errors: |
Sir I didn't understand how can a validation error come from line 5999 when I did not even change the line, seems strange. |
|
This is a shared docstring so it's used by 2 other functions. I think |
thanls sir done the changes |
mroeschke
approved these changes
Nov 11, 2022
|
Thanks @ramvikrams |
Thank you sir for your help all along |
codamuse
pushed a commit
to codamuse/pandas
that referenced
this pull request
Nov 12, 2022
…49556) * for pandas-dev#49508 changing Doc for DataFrame.astype added the series in input in the doc of DataFrame.astype * up * up2 * up3 * up4 * up5
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
…49556) * for pandas-dev#49508 changing Doc for DataFrame.astype added the series in input in the doc of DataFrame.astype * up * up2 * up3 * up4 * up5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the series in input in the doc of DataFrame.astype
closes #49508