CLN: Deduplicate code in duplicated #49550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Nov 5, 2022
| for i in range(n - 1, -1, -1): | ||
| # equivalent: range(n)[::-1], which cython doesn't like in nogil |
There was a problem hiding this comment.
is this comment no longer relevant?
There was a problem hiding this comment.
It is still relevant, but imo
range(n - 1, -1, -1)
is clearer than range(n)[::-1] anyway, so thought removing this would be fine.
mroeschke
approved these changes
Nov 7, 2022
|
Thanks @phofl |
phofl
added a commit
to phofl/pandas
that referenced
this pull request
Nov 9, 2022
* CLN: Deduplicate code in duplicated * Clean * Fix
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* CLN: Deduplicate code in duplicated * Clean * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mroeschke
I think you asked for this when implementing the mask support