BUG: Fixed _format_labels in tile.py for np.inf. #4954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you squash to 1 commit? looks good |
|
if you want to put you test example in v0.13.0 you can (to sort of 'announce' this fix)..up2u |
|
I did that, I hope adding the example to the documentation is okay. One question: It's rather unmathematical to write |
| @@ -114,6 +114,15 @@ def test_na_handling(self): | |||
| ex_result = np.where(com.isnull(arr), np.nan, result) | |||
| tm.assert_almost_equal(result, ex_result) | |||
|
|
|||
| def test_inf_handling(self): | |||
| data = np.arange(6) | |||
There was a problem hiding this comment.
Can you also test with Series? thx
|
@filmor Can u rebase? |
Since the fractional part of np.inf is 0.0 it is enough to change the formatter string in this case to the (nearly) equivalent "%.0f".
|
Done. The question still stands though, but it can be handled in a different PR. |
|
I think it's more consistent to use the existing labeling scheme (even if technically mathematically incorrect) |
|
That's fine with me :) |
jreback
added a commit
that referenced
this pull request
Sep 25, 2013
BUG: Fixed _format_labels in tile.py for np.inf.
|
@filmor thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3415.