Skip to content

Refactor sqlalchemy code in pandas.io.sql to help prepare for sqlalchemy 2.0. #49531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Refactor sqlalchemy code in pandas.io.sql to help prepare for sqlalchemy 2.0. #49531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56248c0
DOC: Clarify behavior of DataFrame.to_sql
Nov 15, 2022
57a63c2
CLN: Make SQLDatabase only accept a sqlalchemy Connection.
Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2751,8 +2751,11 @@ def to_sql(
Using SQLAlchemy makes it possible to use any DB supported by that
library. Legacy support is provided for sqlite3.Connection objects. The user
is responsible for engine disposal and connection closure for the SQLAlchemy
connectable See `here \
<https://docs.sqlalchemy.org/en/13/core/connections.html>`_.
connectable. See `here \
<https://docs.sqlalchemy.org/en/14/core/connections.html>`_.
If passing a sqlalchemy.engine.Connection which is already in a transaction,
the transaction will not be committed. If passing a sqlite3.Connection,
it will not be possible to roll back the record insertion.

schema : str, optional
Specify the schema (if database flavor supports this). If None, use
Expand Down
Loading