-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Change flaky to_excel test to use xlsxwriter #49509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Guessing this should now pass with openpyxl as well as xlsxwriter now that we aren't comparing all file contents. Would it make sense to still test openpyxl, or is that redundant? |
I think testing both openpyxl and xlsxwriter would be redundant since it seem the main point of the test is to test a I changed it back to testing openpyxl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @mroeschke |
test_write_fspath_all
has been flaky and failing when comparing the binary xml forto_excel
with openpyxl e.g.This was changed from
xlwt
toopenpyxl
in #49296, seeing ifxlsxwriter
is more stable.