Skip to content

Bug: Don't intercept TypeError in DataFrame.agg #49505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sarvaSanjay
Copy link
Contributor

@sarvaSanjay sarvaSanjay commented Nov 3, 2022

@rhshadrach
Copy link
Member

Thanks for the PR! Could you update the title by clicking the edit button here:

image

to be a bit more descriptive? It can even just be the title from the corresponding issue.

I also suspect there will be a number of test failures; we check the error message and that message will now need to be updated.

@mroeschke mroeschke added Clean Apply Apply, Aggregate, Transform, Map labels Nov 3, 2022
@sarvaSanjay sarvaSanjay changed the title Update apply.py Bug: Don't intercept TypeError in DataFrame.agg Nov 3, 2022
@sarvaSanjay
Copy link
Contributor Author

@rhshadrach,
Thanks for your msg. Sorry about the title. I believe it's better now. Also regarding the test failures, I believe they will have to be fixed at your end? Or would I have to change something in the test folder?

@rhshadrach
Copy link
Member

Title looks great - thanks!

Or would I have to change something in the test folder?

You're changing tested behavior of pandas, and that is going to cause the tests to "fail". The tests that have failed need to be updated with the correct error types and messages.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Dec 5, 2022
@rhshadrach
Copy link
Member

Closing as stale. @sarvaSanjay - if you'd like to continue comment here and we can reopen.

@rhshadrach rhshadrach closed this Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Clean Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Don't intercept TypeError in DataFrame.agg
3 participants