Skip to content

DEP: Enforce respecting group_keys in groupby.apply #49490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@rhshadrach rhshadrach added Groupby Deprecate Functionality to remove in pandas Apply Apply, Aggregate, Transform, Map labels Nov 3, 2022
@rhshadrach rhshadrach added this to the 2.0 milestone Nov 3, 2022
@mroeschke
Copy link
Member

Merge conflict otherwise LGTM

@jorisvandenbossche jorisvandenbossche merged commit d47e052 into pandas-dev:main Nov 8, 2022
@jorisvandenbossche
Copy link
Member

Thanks!

@rhshadrach rhshadrach deleted the enforce_apply_group_keys branch November 8, 2022 18:01
phofl pushed a commit to phofl/pandas that referenced this pull request Nov 9, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Deprecate Functionality to remove in pandas Groupby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants