-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: Add masked engine #49420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ENH: Add masked engine #49420
Changes from 10 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
6f5a8ea
Implement masked engine
phofl a051815
Add tests
phofl 3513430
Fix asv
phofl 2246123
Fix mypy
phofl 1d35e2e
Add test
phofl 797269a
Fix error
phofl 32e6db4
Fix windows builds
phofl 9380873
Merge remote-tracking branch 'upstream/main' into enh_masked_engine
phofl 36a0d29
Fix typing
phofl ddcdb13
Use np arrays
phofl e29a970
Adress review
phofl d258bc3
Merge remote-tracking branch 'upstream/main' into enh_masked_engine
phofl 6fac3b8
Merge remote-tracking branch 'upstream/main' into enh_masked_engine
phofl aec65a7
Adapt to join difference
phofl f0e749a
Merge remote-tracking branch 'upstream/main' into enh_masked_engine
phofl 69113cb
Address review
phofl cadc239
Add todo
phofl 7569039
Merge remote-tracking branch 'upstream/main' into enh_masked_engine
phofl 06fbe03
Move import
phofl e431337
Merge remote-tracking branch 'upstream/main' into enh_masked_engine
phofl 9326c14
Merge remote-tracking branch 'upstream/main' into enh_masked_engine
phofl 44ba473
Refactor
phofl 844155f
Merge remote-tracking branch 'upstream/main' into enh_masked_engine
phofl 1a6fec0
Remove unnecessary function
phofl befac73
Remove unnecessary function
phofl 9945a07
Merge branch 'main' into enh_masked_engine
phofl 5faa2fe
Merge branch 'main' into enh_masked_engine
phofl efde9dd
Combine conditions
phofl 7711ac0
Merge branch 'main' into enh_masked_engine
phofl ca6e8dd
Merge branch 'main' into enh_masked_engine
phofl 958b40e
Merge branch 'main' into enh_masked_engine
phofl 7572eb5
Adjust asv
phofl f2b0a98
Merge remote-tracking branch 'origin/enh_masked_engine' into enh_mask…
phofl be6fb4d
Merge branch 'main' into enh_masked_engine
phofl aab7ed0
Add whatsnew
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NBD but i think if you do this at the class level outside of setup it might only construct once. might add up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we run into risks of caching stuff on the Index level that could impact performance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its possible. could just create the arrays instead of the Index objects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, moved the list construction outside. We should probably think about going over the asvs, we are doing this in a lot of places.