DEPR: Enforce deprecation of na_sentinel #49402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Missing-data
|
mroeschke
reviewed
Oct 31, 2022
…rce_depr_na_sentinel
Co-authored-by: Matthew Roeschke <[email protected]>
…ach/pandas into enforce_depr_na_sentinel
|
@rhshadrach heads up - there's a merge conflict |
…rce_depr_na_sentinel � Conflicts: � doc/source/whatsnew/v2.0.0.rst
|
Thanks @mroeschke, it's now resolved. |
|
circleCI failure looks like its the float->dt64 astype issue, i.e. unrelated |
jbrockmendel
reviewed
Nov 2, 2022
pandas/core/algorithms.py
Outdated
| # We've already warned above | ||
| warnings.filterwarnings("ignore", ".*use_na_sentinel.*", FutureWarning) | ||
| codes, uniques = values.factorize(na_sentinel=na_sentinel_arg) | ||
| # GH#46910 - TimelikeOps has deprecated signature |
There was a problem hiding this comment.
is it not deprecated there too?
There was a problem hiding this comment.
Thanks, missed this one. The deprecation of TimelikeOps signature is taken care of here (in datetimelike.py), just the comment got left behind.
jbrockmendel
reviewed
Nov 2, 2022
| @@ -454,24 +450,6 @@ def __ne__(self, other: Any) -> ArrayLike: # type: ignore[override] | |||
| """ | |||
| return ~(self == other) | |||
|
|
|||
| def __init_subclass__(cls, **kwargs) -> None: | |||
There was a problem hiding this comment.
wow didn't realize we had done this. will be nice to see this go
…ach/pandas into enforce_depr_na_sentinel
…rce_depr_na_sentinel
jorisvandenbossche
approved these changes
Nov 4, 2022
|
@rhshadrach looks like there's a merge conflict; otherwise, looks good to merge |
…rce_depr_na_sentinel � Conflicts: � doc/source/whatsnew/v2.0.0.rst
|
Thanks @rhshadrach |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Nov 9, 2022
* DEPR: Enforce deprecation of na_sentinel * Fixups * Fix docstring * Update doc/source/whatsnew/v2.0.0.rst Co-authored-by: Matthew Roeschke <[email protected]> * Remove comment Co-authored-by: Matthew Roeschke <[email protected]>
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* DEPR: Enforce deprecation of na_sentinel * Fixups * Fix docstring * Update doc/source/whatsnew/v2.0.0.rst Co-authored-by: Matthew Roeschke <[email protected]> * Remove comment Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @jbrockmendel @jorisvandenbossche