-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fixing DataFrame.Update crashes when NaT present #49395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarcoGorelli
merged 11 commits into
pandas-dev:main
from
wxing11:fixing-dataframe-update-crashes
Nov 15, 2022
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2d126dd
Fixes DataFrame.update crashes when NaT present. GH16713
wxing11 b4c792a
Formatting
wxing11 c63d1cc
No longer reindexing columns, skipping non-matching columns
wxing11 7bea232
switching to using set intersection to find shared columns
wxing11 9ee4329
switching to using index intersection
wxing11 f191629
Removing unnecessary variable creation
wxing11 35fa0a8
Formatting and removing test
wxing11 ead244a
Adding to whatsnew
wxing11 bd07c5a
updating whatsnew message
wxing11 8a1e0f7
Merge branch 'main' into fixing-dataframe-update-crashes
MarcoGorelli d8167ea
Update doc/source/whatsnew/v2.0.0.rst
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we clarify please - if I understand correctly, it was only raising a TypeError if the column had NaT values and it wasn't present in the other DataFrame and you were using
overwrite=False
Also, if you write
NaT
, make sure to put double ticks around it, like thisThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the message, let me know if the new one works!