Skip to content

DOC: Removed line about %S parses all the way up to nanosecond even if no #49349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 28, 2022
Merged

DOC: Removed line about %S parses all the way up to nanosecond even if no #49349

Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a458ca7
Removed line about %S parses all the way up to nanosecond even if no …
sarvaSanjay Oct 27, 2022
f0b7640
Deleted example code and changed documentation to though note that %f…
sarvaSanjay Oct 27, 2022
61fa531
Deleted example code and changed documentation to though note that %f…
sarvaSanjay Oct 27, 2022
70877e7
Fixed CI error
sarvaSanjay Oct 27, 2022
81c758d
Changed to %f
sarvaSanjay Oct 27, 2022
de08fcf
Merge branch 'main' into shiny-new-feature
sarvaSanjay Oct 27, 2022
c92efe0
Merge branch 'main' into shiny-new-feature
sarvaSanjay Oct 27, 2022
61cc679
Removed line between format and exact
sarvaSanjay Oct 27, 2022
9f5fedd
Merge branch 'main' into shiny-new-feature
sarvaSanjay Oct 27, 2022
47db927
Merge branch 'main' into shiny-new-feature
sarvaSanjay Oct 27, 2022
14d3a84
removed whitespace at end of line
sarvaSanjay Oct 27, 2022
f709759
Merge branch 'main' into shiny-new-feature
sarvaSanjay Oct 28, 2022
a7e55dd
Re-added formatting to %f
sarvaSanjay Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions pandas/core/tools/datetimes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,15 +782,7 @@ def to_datetime(
`strftime documentation
<https://docs.python.org/3/library/datetime.html
#strftime-and-strptime-behavior>`_ for more information on choices, though
note the following differences:

- :const:`"%f"` will parse all the way
up to nanoseconds;

- :const:`"%S"` without :const:`"%f"` will capture all the way
up to nanoseconds if present as decimal places, and will also handle
the case where the number of seconds is an integer.

Comment on lines -790 to -793
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, the preceding paragraph says "though note the following difference", but then there's only one difference.

Perhaps we can change it to something like

though note that "%f" will parse all the way up to nanoseconds

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have made the necessary changes

note that "%f" will parse all the way up to nanoseconds.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to remove the formatting

Suggested change
note that "%f" will parse all the way up to nanoseconds.
note that :const:`"%f"` will parse all the way up to nanoseconds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I have re-added the formatting.

exact : bool, default True
Control how `format` is used:

Expand Down Expand Up @@ -969,13 +961,6 @@ def to_datetime(
... format='%Y-%m-%d %H:%M:%S.%f')
Timestamp('2018-10-26 12:00:00.000000001')

:const:`"%S"` without :const:`"%f"` will capture all the way
up to nanoseconds if present as decimal places.

Comment on lines -972 to -974
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to remove the example code that follows

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bringing this to my notice, I have deleted the example code.

>>> pd.to_datetime('2017-03-22 15:16:45.433502912',
... format='%Y-%m-%d %H:%M:%S')
Timestamp('2017-03-22 15:16:45.433502912')

**Non-convertible date/times**

If a date does not meet the `timestamp limitations
Expand Down