API: raise on unsupported dtype instead of silently swapping #49285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mroeschke
added
Dtype Conversions
mroeschke
reviewed
Oct 25, 2022
doc/source/whatsnew/v2.0.0.rst
Outdated
|
|
||
| *New behavior*: | ||
|
|
||
| In [5]: pd.Series(["2016-01-01"], dtype="datetime64[s]") |
There was a problem hiding this comment.
I think this should be in a .. ipython:: python block
There was a problem hiding this comment.
its still not happy here
<<<-------------------------------------------------------------------------
WARNING:
>>>-------------------------------------------------------------------------
Exception in /home/runner/work/pandas/pandas/doc/source/whatsnew/v2.0.0.rst at block ending on line 161
Specify :okexcept: as an option in the ipython:: block to suppress this message
Cell In [6], line 1
TypeError: dtype=datetime64[D] is not supported. Supported resolutions are 's', 'ms', 'us', and 'ns'
^
SyntaxError: invalid syntax
There was a problem hiding this comment.
remote the prompts e.g.
pd.Series(.....)
There was a problem hiding this comment.
This section should just be
*New behavior*:
.. ipython:: python
pd.Series(["2016-01-01"], dtype="datetime64[s]")
mroeschke
reviewed
Oct 26, 2022
mroeschke
reviewed
Oct 26, 2022
|
@jreback little help with the docbuild? (also thoughts on the API change?) |
jreback
reviewed
Nov 2, 2022
doc/source/whatsnew/v2.0.0.rst
Outdated
|
|
||
| *New behavior*: | ||
|
|
||
| In [5]: pd.Series(["2016-01-01"], dtype="datetime64[s]") |
There was a problem hiding this comment.
remote the prompts e.g.
pd.Series(.....)
doc/source/whatsnew/v2.0.0.rst
Outdated
| :okexcept: | ||
|
|
||
| In [6]: pd.Series(["2016-01-01"], dtype="datetime64[D]") | ||
|
|
There was a problem hiding this comment.
still getting errors
|
@jreback still struggling with the docbuild |
mroeschke
approved these changes
Nov 8, 2022
|
Thanks @jbrockmendel |
|
sweet! the only big constructor-behavior-matching one left is #49348 |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Nov 9, 2022
…dev#49285) * API: raise on unsupported dtype instead of silently swapping * lint fixup * ipython blocks * okexcept * troubleshoto doc * jeffs suggestion * troubleshoot docbuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Looks like ATM the DataFrame case raises bc it goes through a different path, while the Series case does not.
mentioned in (but this does not close) #48979