-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: GH28635 Add ASV benchmark for resample after groupby #49274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Couple of comments.
What is the runtime of the benchmark? We aim for something like 20ms in general.
The code as I had first submitted it took 100ms per tested function for one run on my machine, I reduced the size of the dataset so that it is below 20ms now on my machine [1]. Of course my machine is not necessarily representative... If this is not the right aproach, anything I should be doing differently?
|
Great, thx |
thx @krasch |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.