BUG: Fix bound checking for Timestamp() with dt64 #4065 #4926
+340
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can u test this in windows? should work but c code changes can sometimes do weird things |
|
Is there any easy way to do that online or do I need to dust off a windows VM? |
|
http://pandas.pydata.org/pandas-docs/dev/install.html for 32-bit 64-bit a little bit non-trivial; there are some online guides |
To fix the bug, this change adds bounds checking to _get_datetime64_nanos() for numpy datetimes that aren't already in [ns] units. Additionally, it updates _check_dts_bounds() to do the bound check just based off the pandas_datetimestruct, by comparing to the minimum and maximum valid pandas_datetimestructs for datetime64[ns]. It is simpler and more accurate than the previous system. Also includes a number of small refactors/fixes to deal with new error cases that didn't exist when invalid datetime64s were just silently coerced into the valid datetime64[ns] range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4065
To fix the bug, this change adds bounds checking to
_get_datetime64_nanos() for numpy datetimes that aren't already in [ns]
units.
Additionally, it updates _check_dts_bounds() to do the bound check just
based off the pandas_datetimestruct, by comparing to the minimum and
maximum valid pandas_datetimestructs for datetime64[ns]. It is simpler
and more accurate than the previous system.