BUG: UndefinedVariableError in DataFrame.query with classname

[debnathshoham]

• closes BUG: UndefinedVariableError in DataFrame.query if name is type #48694
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• Added type annotations to new arguments/methods/functions.
• Added an entry in the latest doc/source/whatsnew/v1.5.2.rst file if fixing a bug or adding a new feature.

xref #47859

[mroeschke]

The doc build error may possibly be related? https://github.com/pandas-dev/pandas/actions/runs/3303682683/jobs/5451910616

[debnathshoham]

Thanks for the feedback @mroeschke.
I see a lot of exceptions in user_guide/enhancingperf.rst, but I was able to build it locally without any error. Any advice how I can figure this out?

[mroeschke]

Did you build the docs locally with the --warnings-are-errors flag?

[debnathshoham]

I used both --warnings-are-errors --single user_guide/enhancingperf.rst, didn't throw any error.

[mroeschke]

From the logs it appears that the errors are not just in --single user_guide/enhancingperf.rst so maybe try building the entire dogs with the --warnings-are-errors flag

[debnathshoham]

I was able to replicate the error in the docs with that. But not able to identify why it's throwing ValueError in the docs, but not in the terminal for the exact same thing.

[mroeschke]

Shouldn't self.env.scope.get("column") == local_name always produce a bool?

[debnathshoham]

yes, ideally it should.
Although the tests were fine, but it threw the error you mentioned up here #49248 (comment)

[mroeschke]

Not too familiar with this part of the codebase, but is there a way to check if it's local without checking if it's a series?

[debnathshoham]

the error on the docs were specific to Series (either local_name or self.env.scope.get("column"))
One example below

[mroeschke]

Can the self.env.scope.get("column") Series name just be compared to the local_name?

[debnathshoham]

so something like

• check if Series
• compare self.env.scope["column"].name with local_name
• if not Series compare directly self.env.scope["column"]

sorry but how is that any better?

EDIT: or did you mean just compare the Series.name? but for most cases, they aren't Series

[mroeschke]

(This may be my ignorance to this part of the code base), but I assumed that self.env.scope["column"] would refer to a Series object and the local_name would refer to the name of the Series so no Series checking needs to be done.

[debnathshoham]

Oh, no that's not the case. Usually it's name of a df column.

I did the Series check just to cover the Sphinx errors. Maybe someone with better Sphinx knowledge can fix this more elegantly.

[github-actions]

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

[phillipuniverse]

Should also fix #49248 #50442

[mroeschke]

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.