BUG: pandas.to_datetime() does not respect exact format string with ISO8601 #49232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
simpler-exact-info
branch
from
a65e8ab to
3eb6dff
Compare
MarcoGorelli
force-pushed
the
simpler-exact-info
branch
from
3eb6dff to
975e313
Compare
MarcoGorelli
commented
Oct 21, 2022
pandas/_libs/tslib.pyx
Outdated
Comment on lines
517
to
518
| char inferred_format[100] | ||
| int inferred_format_len |
There was a problem hiding this comment.
hi @WillAyd - I don't have much experience with C, what would be a better way to do this?
What I'm trying to do is:
- make a character array
inferred_formatin which to record the format which is guessed withinparse_iso_8601_datetime - record the length of the inferred format into
inferred_format_len
and then compare format with inferred_format[:inferred_format_len]
I'll try to figure this out, but I'm aware that char inferred_format[1000] is not the solution, just seeing if I can get something working first
EDIT: looks like strcat from string.h could work for this
EDIT2: passing a string to parse_iso_8601_datetime that gets written to is proving too hard, I think I'll just try a simpler approach of passing format to parse_iso_8601_datetime, and checking that the inferred format matches it as it gets parsed
|
closing, will take this forward in #49333, will add some commits there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I'm working on cleaning up / deduplicating the code