Skip to content

DOC: show disallowed eval syntax #4922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2013
Merged

DOC: show disallowed eval syntax #4922

merged 1 commit into from
Sep 22, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 21, 2013

closes #4898

@cpcloud
Copy link
Member Author

cpcloud commented Sep 21, 2013

@jreback @jtratner speak now or forever git revert your peace.

@ghost ghost assigned cpcloud Sep 21, 2013
@jtratner
Copy link
Contributor

I'd say that this is not an exhaustive list.

@jtratner
Copy link
Contributor

e.g., "We've made an effort to keep this syntax simple and clean. As of now, these syntax elements are not supported and support is not planned for the future (not an exhaustive list)."

@cpcloud
Copy link
Member Author

cpcloud commented Sep 21, 2013

I'd say that this is not an exhaustive list.

I did look at the set of disallowed nodes for the pandas parser, so I would say it is (unless I missed something), as far as user-facing syntactic categories go.

@jtratner
Copy link
Contributor

great - then never mind :)

@cpcloud
Copy link
Member Author

cpcloud commented Sep 21, 2013

Here are the disallowed expression nodes:

frozenset(['Set', 'SetComp', 'Repr', 'Yield', 'Call', 'DictComp', 'Dict', 'IfExp', 'GeneratorExp', 'Lambda'])

@cpcloud
Copy link
Member Author

cpcloud commented Sep 21, 2013

So you're right, I missed yield and generators

@cpcloud
Copy link
Member Author

cpcloud commented Sep 21, 2013

I think Repr is for interactive stuff....let me check

@jreback
Copy link
Contributor

jreback commented Sep 21, 2013

maybe have allowed syntax just to make it obvious?

@jreback
Copy link
Contributor

jreback commented Sep 21, 2013

I mean in addition to disalllowed

@cpcloud
Copy link
Member Author

cpcloud commented Sep 21, 2013

let me see how long that list is ....

@cpcloud
Copy link
Member Author

cpcloud commented Sep 22, 2013

list is pretty long .. i'll just add a smaller list encompassing a bunch of ops per bullet point

@cpcloud
Copy link
Member Author

cpcloud commented Sep 22, 2013

@jreback @jtratner merge?

@jreback
Copy link
Contributor

jreback commented Sep 22, 2013

I would switch order, put allowed first, maybe call it Allowed syntax? - or if you can think of a better name

@cpcloud
Copy link
Member Author

cpcloud commented Sep 22, 2013

okay ... what do u think?

@jreback
Copy link
Contributor

jreback commented Sep 22, 2013

good

cpcloud added a commit that referenced this pull request Sep 22, 2013
DOC: show disallowed eval syntax
@cpcloud cpcloud merged commit 16e2f63 into pandas-dev:master Sep 22, 2013
@cpcloud cpcloud deleted the eval-syntax-docs branch September 22, 2013 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation to eval showing what syntax is not available
3 participants