-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
STYLE fix: pylint "consider-using-in" warning #49213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks - could you also run the rest of the pre-commit
checks on these files? else CI will fail
Thanks! Now all the pre-commit checks passed locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fabinca
* consider-using-in * consider-using-in * remove consider using in from pyproject.toml to add it to pylint * after running pre-commit chacks Co-authored-by: carlotta <[email protected]>
* consider-using-in * consider-using-in * remove consider using in from pyproject.toml to add it to pylint * after running pre-commit chacks Co-authored-by: carlotta <[email protected]>
Refers to one of the issues in STYLE fix pylint issues #48855
All code checks passed
I have enabled "consider-using-in" in pylint and fixed the parts in the code corresponding to it. Let me know if I should change anything.