Skip to content

STYLE fix: pylint "consider-using-in" warning #49213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 21, 2022

Conversation

fabinca
Copy link
Contributor

@fabinca fabinca commented Oct 20, 2022

I have enabled "consider-using-in" in pylint and fixed the parts in the code corresponding to it. Let me know if I should change anything.

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Oct 20, 2022
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks - could you also run the rest of the pre-commit checks on these files? else CI will fail

@fabinca
Copy link
Contributor Author

fabinca commented Oct 20, 2022

Thanks! Now all the pre-commit checks passed locally.

@fabinca fabinca requested a review from MarcoGorelli October 20, 2022 21:04
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabinca

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Oct 21, 2022
@MarcoGorelli MarcoGorelli merged commit 2be9661 into pandas-dev:main Oct 21, 2022
phofl pushed a commit to phofl/pandas that referenced this pull request Oct 21, 2022
* consider-using-in

* consider-using-in

* remove consider using in from pyproject.toml to add it to pylint

* after running pre-commit chacks

Co-authored-by: carlotta <[email protected]>
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
* consider-using-in

* consider-using-in

* remove consider using in from pyproject.toml to add it to pylint

* after running pre-commit chacks

Co-authored-by: carlotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants