Skip to content

CLN: Replace _obj_with_exclusions with _select_obj for Series #49136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

CLN: Replace _obj_with_exclusions with _select_obj for Series #49136

merged 1 commit into from
Oct 17, 2022

Conversation

rhshadrach
Copy link
Member

Part of #46944

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

When obj is a Series, _select_obj and _obj_with_exclusions are the same.

@phofl phofl added this to the 2.0 milestone Oct 17, 2022
@phofl phofl merged commit b07e31c into pandas-dev:main Oct 17, 2022
@phofl
Copy link
Member

phofl commented Oct 17, 2022

thx @rhshadrach

@rhshadrach rhshadrach deleted the obj_with_exclusions_ectomy branch October 17, 2022 16:42
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@rhshadrach @noatamir
CLN: Replace _obj_with_exclusions with _select_obj for Series (pandas…
334c97a 
…-dev#49136)
This was referenced Oct 4, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Clean Groupby
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @phofl