Skip to content

DOC: fix versionchanged blank line usage (#49117) #49125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

mathpn
Copy link
Contributor

@mathpn mathpn commented Oct 16, 2022

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mathpn, looks good to me. Did you try to render the docs locally to doubke check thast this renders as expected? Or you can download the artifact with the built docs from the CI too.

@mathpn
Copy link
Contributor Author

mathpn commented Oct 16, 2022

@datapythonista thank you for the review. Yes, docs built locally are rendered as expected ("Changed in version 0.25.0"). However, the CI doc build failed for a reason that looks unrelated to the changes introduced by the commit (URLError: <urlopen error [Errno 104] Connection reset by peer>).

@datapythonista
Copy link
Member

Thanks! Connection errors happen sometimes, let's rerun the CI and see if we're lucky.

@phofl phofl added this to the 2.0 milestone Oct 16, 2022
@phofl phofl added the Docs label Oct 16, 2022
@phofl phofl merged commit 1ef45fd into pandas-dev:main Oct 16, 2022
@phofl
Copy link
Member

phofl commented Oct 16, 2022

thx @mathpn

@mathpn mathpn deleted the 49117-docs-versionchanged-directive branch October 17, 2022 13:58
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Fix versionchanged directive in DataFrame.plot
3 participants