PERF: StringArray from np.str_ array #49109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
added
Performance
lukemanley
changed the title
mroeschke
reviewed
Oct 17, 2022
pandas/_libs/lib.pyx
Outdated
| @@ -703,6 +703,10 @@ cpdef ndarray[object] ensure_string_array( | |||
| if copy and result is arr: | |||
| result = result.copy() | |||
|
|
|||
| if util.is_array(arr) and issubclass(arr.dtype.type, np.str_): | |||
There was a problem hiding this comment.
Should the np.aasarray call above guarantee util.is_array(arr) is always true?
There was a problem hiding this comment.
yep, you're right. I've removed the is_array check. thanks!
mroeschke
approved these changes
Oct 18, 2022
|
Thanks @lukemanley |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* perf: string array from np.str_ * add test * whatsnew * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.0.0.rstfile if fixing a bug or adding a new feature.Perf improvement when constructing a
StringArrayfrom a numpy array with typenp.str_.