REF: _reso->_creso #49107
Merged
REF: _reso->_creso #49107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
approved these changes
Oct 15, 2022
|
thx @jbrockmendel |
abkosar
pushed a commit
to abkosar/pandas
that referenced
this pull request
Oct 22, 2022
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
max0x7ba
reviewed
Nov 17, 2022
| @@ -2103,7 +2103,7 @@ def _round(self, freq, mode, ambiguous, nonexistent): | |||
| values = self.view("i8") | |||
| values = cast(np.ndarray, values) | |||
| nanos = to_offset(freq).nanos # raises on non-fixed frequencies | |||
| nanos = delta_to_nanoseconds(to_offset(freq), self._reso) | |||
| nanos = delta_to_nanoseconds(to_offset(freq), self._creso) | |||
There was a problem hiding this comment.
This discards the result of the previous line. I wonder why the previous line is still needed?
There was a problem hiding this comment.
the previous line likely shouldn't assign nanos =. It is just accessing .nanos so that we get the right exception message if that raises
There was a problem hiding this comment.
... we get the right exception message if that raises
That's exactly how I got there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.