CLN/TST: Convert tests/tseries/offset to pytest idioms
#49095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
jreback
requested changes
Oct 21, 2022
| @@ -29,3 +32,11 @@ def month_classes(request): | |||
| Fixture for month based datetime offsets available for a time series. | |||
| """ | |||
| return request.param | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
There was a problem hiding this comment.
how about date or dt for the name?
| def test_immutable(self, offset_types): | ||
| # GH#21341 check that __setattr__ raises | ||
| offset = self._get_offset(offset_types) | ||
| offset = _create_offset(offset_types) |
There was a problem hiding this comment.
shouldn't you make a new fixture that does this
There was a problem hiding this comment.
This function is also used in the testing class helper methods so I think this is better (for now) as a separate function
|
Addressed and green |
jreback
approved these changes
Oct 21, 2022
|
thanks @mroeschke |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup_methodtopytest.fixtures where neededBaseclass (tests were moved in CLN: tseries/offsets base tests #49017) and refactored to a stand alone function