Skip to content

DEP: Enforce numpy keyword deprecation in read_json #49083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 20, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Oct 14, 2022

@phofl phofl added IO JSON read_json, to_json, json_normalize Deprecate Functionality to remove in pandas labels Oct 14, 2022
@phofl phofl added this to the 2.0 milestone Oct 14, 2022
@WillAyd
Copy link
Member

WillAyd commented Oct 19, 2022

Can you also remove the relevant code from JSONToObj.c?

@WillAyd
Copy link
Member

WillAyd commented Oct 19, 2022

Some pointers that may be helpful:

  1. Should be able to remove the dtype struct member:

  2. Can remove from kwargs:

    static char *g_kwlist[] = {"obj", "precise_float", "numpy",

  3. Can remove local variable reference:

    int numpy = 0, labelled = 0;

And any references of that variable you find

@phofl
Copy link
Member Author

phofl commented Oct 19, 2022

Not sure if I got everything.

I don't think we can remove the dtype, it is also used for dtype inference if nothing is passed

@WillAyd
Copy link
Member

WillAyd commented Oct 20, 2022

Nice cleanup - lgtm after conflict fixup

@phofl phofl merged commit 2410fca into pandas-dev:main Oct 20, 2022
@phofl phofl deleted the dep_read_json_numpy branch October 20, 2022 11:03
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas IO JSON read_json, to_json, json_normalize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants