DEP: Enforce deprecation of squeeze argument in groupby #49082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
approved these changes
Oct 14, 2022
Comment on lines
-902
to
+905
| key = Timestamp("2013-12-31") | ||
| ordering = df["Date"].sort_values().dropna().index | ||
| mi = MultiIndex.from_product([[key], ordering], names=["Date", None]) | ||
|
|
||
| ex_values = df["Quantity"].take(ordering).values * 2 | ||
| expected = Series(ex_values, index=mi, name="Quantity") | ||
| tm.assert_series_equal(res, expected) | ||
| expected = DataFrame( | ||
| [[36, 6, 6, 10, 2]], | ||
| index=Index([Timestamp("2013-12-31")], name="Date"), | ||
| columns=Index([0, 1, 5, 2, 3], name="Quantity"), | ||
| ) | ||
| tm.assert_frame_equal(res, expected) |
WillAyd
requested changes
Oct 19, 2022
|
|
||
| with tm.assert_produces_warning(FutureWarning, match="`squeeze` parameter"): | ||
| gb = df.groupby(tdg, squeeze=True) | ||
| gb = df.groupby(tdg) |
There was a problem hiding this comment.
I think you can just remove this entire test as it was intentionally testing the squeeze functionality
There was a problem hiding this comment.
Yeah true, but this shows nicely how it changed in cases where squeeze had an actual effect. I think this would be nice in our history if someone wants to go back and have a look
WillAyd
approved these changes
Oct 20, 2022
|
@phofl looks like a merge conflict needs fixing - otherwise good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32380