REF: sequence_to_dt64ns #49040
Merged
REF: sequence_to_dt64ns #49040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 11, 2022
| @@ -308,18 +308,33 @@ def _from_sequence_not_strict( | |||
| ): | |||
There was a problem hiding this comment.
Would be great to add a docstring for _from_sequence_not_strict while here. Not completely obvious what "not strict" means relative to _from_sequence
There was a problem hiding this comment.
good idea. will add that in the follow-up branch
mroeschke
added
Refactor
|
Thanks @jbrockmendel |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* REF: sequence_to_dt64ns * update test * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken off from a branch implementing non-nano support for DatetimeArray constructors.