Fixing issue #4902.

[alefnula]

closes #4902, Added a check for complex numbers.

[cpcloud]

@alefnula Can you add a test if you aren't doing that already? Thanks :)

[jreback]

release notes as well!

[cpcloud]

@alefnula just fyi those are in doc/source/release.rst

[alefnula]

Uh sorry, I'm not that familiar with the pandas project workflow yet. Can someone point me what should I add to release notes, and in which test suite/test file should the test for pandas.core.nanops._ensure_numeric go? The function is also private for the module and I don't see it used anywhere else, so should I test it directly or using just the public api.

I'm really sorry for this many questions. :-/

[cpcloud]

@alefnula No problem.

1. As I said above, release notes are in pandas/doc/source/release.rst
2. Test it on something similar to the SO question, e.g., create a heterogeneously typed DataFrame and compute the mean. Something like,

def test_complex_mean(self):
    df = DataFrame({'a': tm.choice(['a', 'b'], size=10), 'b': rand(10).astype(complex) + randn(10) * 1j})
    result = df.mean().item()
    expected = df['b'].values.mean()
    self.assertEqual(result, expected)

[alefnula]

@cpcloud OK got it. One more question. test_series.py - is this an appropriate place for this test? Since this happens on every aggregate operation on a Series object.

[jreback]

@alefnula yes...can put it there....try to find a similar group of tests and try it (note that make sure its NOT under SafeForSparse), because I don't think this works on sparse

[alefnula]

@jreback I just found a test_ensure_int32 int test_common.py. Maybe this is a better place for test_ensure_numeric since it's testing the exact change?

[jreback]

@alefnula that's fine too

[jreback]

@alefnula do you have travis hookup up? see contributing.md for instructions...

[alefnula]

Added tests, updated the release.rst.

[alefnula]

@jreback Enabled travis. But saw your post too late, already pushed the changes. :-/

[jreback]

go ahead and set up travis, then

git commit --amend -C HEAD
will trigger travis with a new commit hash

[alefnula]

@jreback Succeeded :) Than you and @cpcloud for assistance. :)

[jreback]

looks good....pls rebase and squash to 1 commit and should be mergeable

[cpcloud]

no need to close ....

[alefnula]

@cpcloud I'm haven't closed it. Github automatically closed it when I rebased and pushed.

[cpcloud]

strange

[jtratner]

yeah, that's not supposed to happen at all. very weird.

[cpcloud]

wonder if the commit message has naything to do with it?

[alefnula]

It happened two times... When I did the amend and when I rebased :-/

[cpcloud]

that's very weird since "fixing" is not one of the words that closes an issue

[jreback]

thanks!