Skip to content

STYLE check for ability to remove 'c-extension-no-member' from pylint exclusions #49038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2022
Merged

STYLE check for ability to remove 'c-extension-no-member' from pylint exclusions #49038

merged 2 commits into from
Oct 11, 2022

Conversation

roadswitcher
Copy link
Contributor

Removed c-extension-no-member from pyproject.toml, ran the precommit checks in Docker build environment, found no instances of the error.

Looks like c-extension-no-member can be removed from the list of pylint exclusions in pyproject.toml

@roadswitcher
Copy link
Contributor Author

OK, that's decidedly odd -- nothing found in the code by pylint, but if I enable the check the pylint process fails on the Ubuntu workflow? I'll have to look into this more.

@MarcoGorelli
Copy link
Member

it's almost certainly unrelated, don't worry about it

@roadswitcher
Copy link
Contributor Author

it's almost certainly unrelated, don't worry about it

I'm choosing to view this as a Self Guided Learning Experience into the intricacies of Github Actions, and not as something to worry about.

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Oct 11, 2022
@mroeschke mroeschke added this to the 1.6 milestone Oct 11, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merge when ready @MarcoGorelli

@MarcoGorelli MarcoGorelli merged commit feea326 into pandas-dev:main Oct 11, 2022
@MarcoGorelli
Copy link
Member

thanks @roadswitcher

@roadswitcher roadswitcher deleted the find_c_extension_no_member branch October 11, 2022 17:42
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants