STYLE: Fix or suppress non-iterator-returned errors from pylint #49036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roadswitcher
changed the title
mroeschke
reviewed
Oct 11, 2022
pandas/tests/io/test_html.py
Outdated
| @@ -1280,6 +1280,8 @@ def seek(self, offset): | |||
| def seekable(self): | |||
| return True | |||
|
|
|||
| # GH 48855 suppressing false positives | |||
| # pylint: disable-next=non-iterator-returned | |||
There was a problem hiding this comment.
Can this be corrected such that the check and existing test passes?
There was a problem hiding this comment.
I'll give that a shot this evening.
There was a problem hiding this comment.
After reviewing #17975 ( issue prompting this test), I added __next__ and changed __iter__ to remove the warning from pylint while letting existing test pass.
…/pandas into check_non_iterator_returned
mroeschke
approved these changes
Oct 12, 2022
|
Thanks @roadswitcher |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…as-dev#49036) * Working on finding issues with non-iterator-returned * Found one instance to suppress * Misread the error message, suppressed wrong line. * Change test so that pylint treats it as iterator * Fix formatting. * Added reference to PR in comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non-iterator-returned) from STYLE fix pylint issues #48855Found one instance of a test that's deliberately returning an Iterator to fool
is_file_like, suppressing the warning as a false positive based on nature of test.