Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Summary
Looks to fix #27437 where the integer index should fallback to positional. I identified that the private method
_should_fallback_to_positional
returned the expressionreturn self.dtype.subtype.kind in ["m", "M"]
which was missing thenumpy.dtype.kind
for single integers and floats as expressed here.However, extending the list with
["i", "f"]
caused the character count to exceed 88, hence extracting this out in the previous line and storing as a variable to reference.Tests are also included which aims to mimic the example given in the issue where the
series
is constructed with aCategoricalIndex
with intervals.Also, this is my first time contributing to the project so would appreciate feedback 👍
Edit
There are a couple things I need to fix
.loc[index]
from unittest as this wasn't the desired property