Skip to content

TST/CLN: Avoid subprocess shell=True #49033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 13, 2022
Merged

TST/CLN: Avoid subprocess shell=True #49033

merged 6 commits into from
Oct 13, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Clean labels Oct 10, 2022
MarcoGorelli
MarcoGorelli approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, that's a good one to avoid

@jbrockmendel
Copy link
Member

LGTM pending green

phofl
phofl reviewed Oct 11, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the failures look legit, restarted the jobs yesterday after they failed initially too

@phofl phofl added this to the 2.0 milestone Oct 13, 2022
@phofl phofl merged commit 7aa391e into pandas-dev:main Oct 13, 2022
@phofl
Copy link
Member

phofl commented Oct 13, 2022

thx @mroeschke

@mroeschke mroeschke deleted the test/cln/no_shell branch October 13, 2022 22:51
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@mroeschke @noatamir
TST/CLN: Avoid subprocess shell=True (pandas-dev#49033)
350654d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mroeschke @jbrockmendel @phofl @MarcoGorelli