-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG/PERF: MultiIndex setops with sort=None #49010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 10, 2022
mroeschke
reviewed
Oct 11, 2022
mroeschke
approved these changes
Oct 12, 2022
Thanks @lukemanley |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* perf: algos.safe_sort with multiindex * add sort to multiindex setop asv * fix asv * whatsnew * update test_union_nan_got_duplicated * add test for sort bug * parameterize dtype in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
MultiIndex
Performance
Memory or execution speed performance
setops
union, intersection, difference, symmetric_difference
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.6.0.rst
file if fixing a bug or adding a new feature.Simplify and improve perf in algos.safe_sort which improves perf in MultiIndex setops when sort=None.
I updated the expected value in
test_union_nan_got_duplicated
which was added in #38977.MultiIndex.union
sorts by default but the expected value in that test was not sorted.For reference, here are the docs for the sort parameter:
pandas/pandas/core/indexes/base.py
Lines 3297 to 3305 in 55dc324