REF: avoid sanitize_to_nanoseconds #49009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 10, 2022
| # Timestamps like | ||
| # TODO 2022-10-08 we only have one test that gets here and | ||
| # values are already in nanoseconds in that case. | ||
| self.grouping_vector = Series(self.grouping_vector).to_numpy() |
There was a problem hiding this comment.
So Series(...).to_numpy() will coerce to nanos and then output to numpy? Is this a lot slower than sanitize_to_nanoseconds?
There was a problem hiding this comment.
So Series(...).to_numpy() will coerce to nanos and then output to numpy?
Yes.
Is this a lot slower than sanitize_to_nanoseconds?
A bit. Adds about 65 microseconds.
There was a problem hiding this comment.
Okay. I guess that's a fair tradeoff for being able to clean up sanitize_to_nanoseconds in #48670
mroeschke
approved these changes
Oct 10, 2022
|
Thanks @jbrockmendel |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* REF: avoid sanitize_to_nanoseconds * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the usages are unnecessary bc we go through the DTA/TDA constructors. After this there is only one left, and that will be removed by #48670