DOC: Fix typos and standardize spelling of "GitHub" and "macOS" #49005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcbeltramini
changed the title
phofl
reviewed
Oct 8, 2022
pandas/tests/io/sas/test_sas7bdat.py
Outdated
| @@ -96,7 +96,7 @@ def test_path_localpath(self, dirpath, data_test_ix): | |||
| @pytest.mark.parametrize("chunksize", (3, 5, 10, 11)) | |||
| @pytest.mark.parametrize("k", range(1, 17)) | |||
| def test_iterator_loop(self, dirpath, k, chunksize): | |||
| # github #13654 | |||
| # GitHub issue #13654 | |||
There was a problem hiding this comment.
I'd prefer keeping this as is to keep git blame. This is an internal comment, so the spelling does not matter much
phofl
approved these changes
Oct 11, 2022
|
thx @gcbeltramini |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix some typos. They were found with:
The output was visually inspected to find the typos.
Standardize spelling of "GitHub". The official spelling of "GitHub" can be seen in the title of page https://github.com/.
Standardize spelling of "macOS". The Apple operating system was called "Mac OS X" in versions 10.0-10.7, then "OS X" in versions 10.8-10.11, and finally "macOS" since version 10.12, released in 2016 (https://en.wikipedia.org/wiki/MacOS#Release_history).
Checklist
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.