Skip to content

REGR: to_parquet raising with bytes filename #48995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 12, 2022
Merged

REGR: to_parquet raising with bytes filename #48995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
873f5f5
REGR: to_parquet raising with bytes filename
phofl Oct 7, 2022
3e60882
Add check
phofl Oct 7, 2022
e93dd00
Fix typo
phofl Oct 10, 2022
c3b258b
Parametrize
phofl Oct 11, 2022
bc43620
Merge remote-tracking branch 'upstream/main' into 48944
phofl Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.5.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ Fixed regressions
- Fixed Regression in :meth:`DataFrameGroupBy.apply` when user defined function is called on an empty dataframe (:issue:`47985`)
- Fixed regression in :meth:`DataFrame.apply` when passing non-zero ``axis`` via keyword argument (:issue:`48656`)
- Fixed regression in :meth:`Series.groupby` and :meth:`DataFrame.groupby` when the grouper is a nullable data type (e.g. :class:`Int64`) or a PyArrow-backed string array, contains null values, and ``dropna=False`` (:issue:`48794`)
- Fixed regression in :meth:`DataFrame.to_parquet` raising when file name was specified as ``bytes`` (:issue:`48944`)
- Fixed regression in :class:`ExcelWriter` where the ``book`` attribute could no longer be set; however setting this attribute is now deprecated and this ability will be removed in a future version of pandas (:issue:`48780`)

.. ---------------------------------------------------------------------------
Expand Down
2 changes: 2 additions & 0 deletions pandas/io/parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ def write(
and isinstance(path_or_handle.name, (str, bytes))
):
path_or_handle = path_or_handle.name
if isinstance(path_or_handle, bytes):
path_or_handle = path_or_handle.decode()

try:
if partition_cols is not None:
Expand Down
10 changes: 10 additions & 0 deletions pandas/tests/io/test_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,3 +1179,13 @@ def test_close_file_handle_on_read_error(self):
read_parquet(path, engine="fastparquet")
# The next line raises an error on Windows if the file is still open
pathlib.Path(path).unlink(missing_ok=False)

def test_bytes_file_name(self, engine):
# GH#48944
df = pd.DataFrame(data={"A": [0, 1], "B": [1, 0]})
with tm.ensure_clean("test.parquet") as path:
with open(path.encode(), "wb") as f:
df.to_parquet(f)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you parameterize over the engine (pyarrow and fastparquet)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was originally referring to engine in to_parquet, but thanks for also add it in read_parquet

Copy link
Member Author

@phofl phofl Oct 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, mixed that up. to_parquet does not work, because it does not support BufferedWriter as path for fast parquet

Traceback (most recent call last):
  File "/Users/patrick/Library/Application Support/JetBrains/PyCharm2022.2/scratches/scratch.py", line 272, in <module>
    df.to_parquet(f, engine="fastparquet")
  File "/Users/patrick/mambaforge/envs/random/lib/python3.10/site-packages/pandas/util/_decorators.py", line 207, in wrapper
    return func(*args, **kwargs)
  File "/Users/patrick/mambaforge/envs/random/lib/python3.10/site-packages/pandas/core/frame.py", line 2835, in to_parquet
    return to_parquet(
  File "/Users/patrick/mambaforge/envs/random/lib/python3.10/site-packages/pandas/io/parquet.py", line 420, in to_parquet
    impl.write(
  File "/Users/patrick/mambaforge/envs/random/lib/python3.10/site-packages/pandas/io/parquet.py", line 301, in write
    self.api.write(
  File "/Users/patrick/mambaforge/envs/random/lib/python3.10/site-packages/fastparquet/writer.py", line 1231, in write
    write_simple(filename, data, fmd,
  File "/Users/patrick/mambaforge/envs/random/lib/python3.10/site-packages/fastparquet/writer.py", line 880, in write_simple
    with open_with(fn, mode) as f:
TypeError: expected str, bytes or os.PathLike object, not BufferedWriter

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay. Guess it's a limitation in fastparquet then.


result = read_parquet(path, engine=engine)
tm.assert_frame_equal(result, df)