Skip to content

DOC: replace developer meeting with contributor community page #48990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 13, 2022

Conversation

noatamir
Copy link
Member

@noatamir noatamir commented Oct 7, 2022

Updating the developer meeting page to include the new contributor meeting and slack
Along the way, I decided to include other communication channels and did my best to describe them, making this more of an internal contributor community page.

Inspired by SciPy and NumPy's community pages, and Matplotlib's home page resources and meeting documentation, and readme.

I tried to keep this pandas' community page as much as possible. Please provide feedback on what you would like to see changed, so it's more appropriate.

I would suggest we add redirects for the old page to this one. If you have an example for how this was done before, I could add it to this PR. Otherwise, I will investigate if Sphinx supports this.

@jorisvandenbossche
Copy link
Member

I would suggest we add redirects for the old page to this one. If you have an example for how this was done before, I could add it to this PR. Otherwise, I will investigate if Sphinx supports this.

We currently have some manual setup for redirects in conf.py, but tailored to generated API pages. Either you could adapt that a bit to work with generic pages, or otherwise we can use some sphinx extension (eg https://documatt.gitlab.io/sphinx-reredirects/index.html)

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments, overall setup looks good to me

@mroeschke mroeschke added the Docs label Oct 7, 2022
@mroeschke mroeschke added this to the 1.6 milestone Oct 7, 2022
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

a General thought: I think potential new contributors would benefit from this being visible on the stable docs

any thoughts on backporting?

@noatamir
Copy link
Member Author

noatamir commented Oct 7, 2022

I think I just added the redirect – but check me 😉

@phofl phofl modified the milestones: 1.6, 1.5.1 Oct 7, 2022
@phofl
Copy link
Member

phofl commented Oct 7, 2022

Looks good, labelling 1.5.1 for now so that we can backport if there aren't any objections from others

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for writing up this page! That's really useful content. Just a few tiny comments

@jorisvandenbossche
Copy link
Member

The doc build failure seems to be related:

 /home/runner/work/pandas/pandas/doc/source/development/index.rst:26: WARNING: toctree contains reference to nonexisting document 'development/meeting'
looking for now-outdated files... none found
pickling environment... done
/home/runner/work/pandas/pandas/doc/source/development/community.rst: WARNING: document isn't included in any toctree

The /docs/source/development/index.rst file still needs to be updated

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche
Copy link
Member

Looks good, labelling 1.5.1 for now so that we can backport if there aren't any objections from others

Generally we don't do the effort of backporting doc fixes, but given that it would be useful to have this updated soon and this shouldn't give conflicts, sounds good to me.

@jorisvandenbossche jorisvandenbossche merged commit 67d75f3 into pandas-dev:main Oct 13, 2022
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 13, 2022
phofl pushed a commit that referenced this pull request Oct 13, 2022
…th contributor community page) (#49067)

Backport PR #48990: DOC: replace developer meeting with contributor community page

Co-authored-by: Noa Tamir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants