-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: pd.compare does not recognize differences when comparing values with null Int64 data type #48966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
BUG: pd.compare does not recognize differences when comparing values with null Int64 data type #48966
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f027ff9
BUG: df.compare returns incorrect result when comparing NA values
vamsi-verma-s 0f3fcef
add bug fix note
vamsi-verma-s 9c0a19b
add pd.compare tests specific to int64 null dtype
vamsi-verma-s 0b5ec5c
change bug fix note to be specifically about int64 dtype null values
vamsi-verma-s d72e0e3
change bug fix note
vamsi-verma-s 4412e33
add nullable int64 test and parameterize ea and np dtype test
vamsi-verma-s 9b97320
fix test parametrization
vamsi-verma-s ffbb131
Merge branch 'master' into res-48939
vamsi-verma-s bae0808
Merge branch 'master' into res-48939
vamsi-verma-s 4838dc0
rename variables, add gh refs
vamsi-verma-s 3f739dd
change var name
vamsi-verma-s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed variable names, please do suggest any alternate if this does not make sense