Skip to content

REF: tighter typing in datetimelike arith methods #48962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2022
Merged

REF: tighter typing in datetimelike arith methods #48962

merged 1 commit into from
Oct 6, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added Refactor Internal refactoring of code Numeric Operations Arithmetic, Comparison, and Logical operations Typing type annotations, mypy/pyright type checking Datetime Datetime data dtype labels Oct 5, 2022
@mroeschke mroeschke added this to the 1.6 milestone Oct 6, 2022
@mroeschke mroeschke merged commit e4dd35f into pandas-dev:main Oct 6, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-checked_add-4 branch October 6, 2022 17:02
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@jbrockmendel @noatamir
REF: tighter typing in datetimelike arith methods (pandas-dev#48962)
9004a5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype Numeric Operations Arithmetic, Comparison, and Logical operations Refactor Internal refactoring of code Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke