Implement get_supported_reso #48956
Merged
Implement get_supported_reso #48956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mroeschke
reviewed
Oct 5, 2022
| cpdef NPY_DATETIMEUNIT get_supported_reso(NPY_DATETIMEUNIT reso): | ||
| # If we have an unsupported reso, return the nearest supported reso. | ||
| if reso == NPY_DATETIMEUNIT.NPY_FR_GENERIC: | ||
| # TODO: or raise ValueError? trying this gives unraisable errors, but |
There was a problem hiding this comment.
Yeah I would support raising. I image this would cause silent failures. Okay to follow up
There was a problem hiding this comment.
An alternative is to just return NPY_FR_GENERIC and have the caller check for it? Or I imagine other code paths would raise (albeit probably with not an entirely clear message)
mroeschke
approved these changes
Oct 5, 2022
mroeschke
added
the
Non-Nano
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find myself implementing this in a bunch of branches, so splitting it off into a separate PR.