Skip to content

BLD: Build arm64 wheels on CircleCI #48952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 10, 2023

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Draft pending #48945 merge.
Uploading also needs to be figuring out.
Most likely will use the Trigger CircleCI action, passing in the env vars.

@lithomas1 lithomas1 added the Build Library building on various platforms label Oct 5, 2022
@WillAyd
Copy link
Member

WillAyd commented Oct 27, 2022

Looks like the dependency is merged - is this ready to come out of draft status?

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Dec 29, 2022
@datapythonista
Copy link
Member

@lithomas1 should we run the CI for this, and see if it works as expected?

@lithomas1
Copy link
Member Author

This PR works(sans uploading), but we need someone to add the Anaconda upload tokens to CircleCI.
(It's probably wise to hold off on that for now, while they sort out their security breach).

@TomAugspurger Can you add me to the scipy-wheels-nightly and multibuild-wheels-staging Anaconda orgs? I am also lithomas1 on anaconda.

@TomAugspurger
Copy link
Contributor

@lithomas1 I added you to both those.

@lithomas1 lithomas1 removed the Stale label Jan 22, 2023
@lithomas1 lithomas1 removed the Build Library building on various platforms label Feb 9, 2023
@lithomas1 lithomas1 marked this pull request as ready for review February 9, 2023 12:18
@lithomas1 lithomas1 added the Build Library building on various platforms label Feb 9, 2023
@lithomas1 lithomas1 added this to the 2.0 milestone Feb 9, 2023
@lithomas1
Copy link
Member Author

OK, this is ready now, I will still have to add the token to CircleCI after this is merged, though.

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroeschke
Copy link
Member

I guess this is the first time testing Windows + ARM and looks like test_ea_dtypes_and_scalar_operation is failing.

Seems like this line should account for is_platform_arm()

[1, 1], dtype="int64" if not is_platform_windows() else "int32"

@lithomas1
Copy link
Member Author

I guess this is the first time testing Windows + ARM and looks like test_ea_dtypes_and_scalar_operation is failing.

Seems like this line should account for is_platform_arm()

[1, 1], dtype="int64" if not is_platform_windows() else "int32"

That's a Windows failure, only, and its failing on main too unfortunately, since recently.

(I should probably document this more, but you find status of the nightly builds by going to Actions -> Wheel builder workflow -> Filter event by schedule).

From https://github.com/pandas-dev/pandas/actions/workflows/wheels.yml?query=event%3Aschedule, it's been failing since yesterday.

I think one thing that would be nice would be to have the Wheel builders automatically open issues for failures (will add to my backlog).

@lithomas1 lithomas1 merged commit 02a6088 into pandas-dev:main Feb 10, 2023
@lithomas1 lithomas1 deleted the cibuildwheel-arm64 branch February 10, 2023 22:36
@phofl
Copy link
Member

phofl commented Feb 11, 2023

This is currently running on my prs. Is this intended?

@lithomas1
Copy link
Member Author

I messed up the grep expression (needed to escape brackets, PR incoming).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants