-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BLD: Build arm64 wheels on CircleCI #48952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like the dependency is merged - is this ready to come out of draft status? |
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
@lithomas1 should we run the CI for this, and see if it works as expected? |
This PR works(sans uploading), but we need someone to add the Anaconda upload tokens to CircleCI. @TomAugspurger Can you add me to the scipy-wheels-nightly and multibuild-wheels-staging Anaconda orgs? I am also lithomas1 on anaconda. |
@lithomas1 I added you to both those. |
OK, this is ready now, I will still have to add the token to CircleCI after this is merged, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I guess this is the first time testing Windows + ARM and looks like Seems like this line should account for
|
That's a Windows failure, only, and its failing on main too unfortunately, since recently. (I should probably document this more, but you find status of the nightly builds by going to Actions -> Wheel builder workflow -> Filter event by schedule). From https://github.com/pandas-dev/pandas/actions/workflows/wheels.yml?query=event%3Aschedule, it's been failing since yesterday. I think one thing that would be nice would be to have the Wheel builders automatically open issues for failures (will add to my backlog). |
This is currently running on my prs. Is this intended? |
I messed up the grep expression (needed to escape brackets, PR incoming). |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Draft pending #48945 merge.
Uploading also needs to be figuring out.
Most likely will use the Trigger CircleCI action, passing in the env vars.