TST/CLN: Use more frame_or_series fixture #48926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Oct 3, 2022
mroeschke
commented
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
mroeschke
added
Testing
jbrockmendel
reviewed
Oct 3, 2022
pandas/tests/extension/base/ops.py
Outdated
| @@ -113,14 +113,13 @@ def test_add_series_with_extension_array(self, data): | |||
| expected = pd.Series(data + data) | |||
| self.assert_series_equal(result, expected) | |||
|
|
|||
| @pytest.mark.parametrize("box", [pd.Series, pd.DataFrame]) | |||
There was a problem hiding this comment.
im on board with this, but in the past @jorisvandenbossche has objected bc it would require library authors to re-implement the fixture
There was a problem hiding this comment.
Ah good point. I didn't realize this was a base extension test so I'll exclude this one.
5 tasks
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* TST/CLN: Use more frame_or_series fixture * Revert for base ext tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.