TST/CLN: Remove ensure_clean_path for tmp_dir fixture #48925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
phofl
reviewed
Oct 5, 2022
pandas/tests/io/pytables/common.py
Outdated
| @@ -45,7 +32,7 @@ def ensure_clean_store( | |||
|
|
|||
| # put in the temporary path if we don't have one already | |||
| if not len(os.path.dirname(path)): | |||
| path = create_tempfile(path) | |||
| path = os.path.join(tempfile.gettempdir(), path) | |||
There was a problem hiding this comment.
Just asking: Is there a reason for using os instead of pathlib? Would prefer the latter because of platform independency
There was a problem hiding this comment.
Probably not; this was just copying over code from create_tempfile. Willl use pathlib here
phofl
approved these changes
Oct 7, 2022
|
thx @mroeschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #26984