Fix assert_almost_equal, add test #48920
Conversation
| @@ -21,7 +21,11 @@ from pandas.core.dtypes.missing import ( | |||
|
|
|||
|
|
|||
| cdef bint isiterable(obj): | |||
| return hasattr(obj, '__iter__') | |||
| if hasattr(obj, '__iter__'): | |||
There was a problem hiding this comment.
I'm not completely convinced this is an appropriate fix to simply exclude 0-D arrays here. This might have unintended consequences where we want to treat 0-D arrays as iterable.
There was a problem hiding this comment.
I've changed it to use try/except. Is this an appropiate fix?
| [ | ||
| (MockNumpyLikeArray(np.ndarray((2,) * 1)), "duck-ndarray-1d"), | ||
| (MockNumpyLikeArray(np.array([])), "duck-ndarray-1d-empty"), | ||
| (MockNumpyLikeArray(np.array(2)), "duck-ndarray-0d"), |
There was a problem hiding this comment.
The description should be passed as a list to ids=[...]
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.