TYP: Axis-related annotations #48907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Oct 1, 2022
| data_columns=None, | ||
| info=None, | ||
| index_axes: list[IndexCol] | None = None, | ||
| non_index_axes: list[tuple[AxisInt, Any]] | None = None, |
There was a problem hiding this comment.
My intenion was to only change the type here, but I also moved the class-level annotations into __init__.
mroeschke
approved these changes
Oct 3, 2022
|
Thanks @twoertwein |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* TYP: Axis-related annotations * black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to limit
_typing.AxisInttoLiteral[0, 1]. That might be feasible in the future when mypy supports more literal math (e.g.,1 - Literal[0, 1] = Literal[0, 1]), but would cause too many errors for now.This PR adds a few Axis-related annotations but does not restrict
AxisIntto{0, 1}.