Skip to content

CLN: move README.rst to markdown #4888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2013
Merged

CLN: move README.rst to markdown #4888

merged 1 commit into from
Sep 19, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 19, 2013

Because GitHub's rst is ugly

@ghost ghost assigned cpcloud Sep 19, 2013
@jreback
Copy link
Contributor

jreback commented Sep 19, 2013

sexy :)

cpcloud added a commit that referenced this pull request Sep 19, 2013
CLN: move README.rst to markdown
@cpcloud cpcloud merged commit cdfae81 into pandas-dev:master Sep 19, 2013
@cpcloud cpcloud deleted the readme-fixup branch September 19, 2013 19:37
@jorisvandenbossche
Copy link
Member

FYI, one of the reasons GitHub's rst is ugly, is not the fault of GitHub, but because the rst in README.rst was not wel formatted ..

Lists should not be indented (something also in the whatsnew and release notes is done wrong), that's why they looked like 'quotes' in the rendering of the README.

@cpcloud
Copy link
Member Author

cpcloud commented Sep 23, 2013

hm i seem to remember shoddy support for rst even with correct, and very basic markup

@jorisvandenbossche
Copy link
Member

If I look at the README.rst, I think the lists is the only issue, apart form not nice rendering of internal links as :func:~pandas.io.html.read_html`` (but you converted them to normal links in the markdown version).

But maybe it has improved over time.

@cpcloud
Copy link
Member Author

cpcloud commented Sep 23, 2013

maybe. do you not like the new version? i think it's simpler and more clear

@jtratner
Copy link
Contributor

does this mess up how PyPI looks?

@cpcloud
Copy link
Member Author

cpcloud commented Sep 23, 2013

arg ... yes it will .... could convert markdown to rst and put that in long
description but that's annoying ... have to change back
https://wiki.python.org/moin/CheeseShopTutorial

Best,
Phillip Cloud

On Mon, Sep 23, 2013 at 6:31 PM, Jeff Tratner [email protected]:

does this mess up how PyPI looks?


Reply to this email directly or view it on GitHubhttps://github.com//pull/4888#issuecomment-24960865
.

@jorisvandenbossche
Copy link
Member

@cpcloud No, I don't really bother about md or rst in the readme. I just saw the issue because there was someone complaining about because of the broken build.
I think the only thing I find less clear in the md version are the headers if you look at the plain text.

And I don't think it is a problem for PyPI, it is already using the LONG_DESCRIPTION in setup.py (but also there, the indentation is wrong).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants