-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DEPR Enforce ewm.vol deprecation #48841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1
−21
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c36fe1e
DEPR Enforce ewm.vol deprecation
mroeschke 3b6dd4b
Merge remote-tracking branch 'upstream/main' into depr/rm/ewm_vol
mroeschke 3d27756
Merge remote-tracking branch 'upstream/main' into depr/rm/ewm_vol
mroeschke 76693f4
Merge remote-tracking branch 'upstream/main' into depr/rm/ewm_vol
mroeschke ef0dac4
add whatsnew note
mroeschke 9d47607
Merge remote-tracking branch 'upstream/main' into depr/rm/ewm_vol
mroeschke 080cb00
Merge remote-tracking branch 'upstream/main' into depr/rm/ewm_vol
mroeschke 34b3669
Merge remote-tracking branch 'upstream/main' into depr/rm/ewm_vol
mroeschke fb7e472
Remove reference to core
mroeschke 396859a
Merge remote-tracking branch 'upstream/main' into depr/rm/ewm_vol
mroeschke 4194fea
Remove unused imports
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically core is considered private, can we reference this in another way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Removed the sphinx directive too since this method won't be reference-able