BUG: DTI-datetime_scalar preserve freq #48818
Merged
+41
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Sep 28, 2022
| @@ -17,6 +17,15 @@ | |||
|
|
|||
|
|
|||
| class TestDatetimeIndex: | |||
| def test_sub_datetime_preserves_reso(self, tz_naive_fixture): | |||
There was a problem hiding this comment.
Could you add a test where this goes over a DST transition?
There was a problem hiding this comment.
good catch. when we cross a DST transition, dti.freq is actually wrong bc of the (deprecated) kludge in generate_range. As a result, inheriting the freq is incorrect in this case. But it will return to being correct once the deprecation is enforced.
i think the thing to do is add the test and xfail it
There was a problem hiding this comment.
test added (and xfailed) + green
mroeschke
added
Numeric Operations
mroeschke
approved these changes
Sep 28, 2022
|
Thanks @jbrockmendel |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* BUG: DTI-datetime_scalar preserve freq * GH ref * add xfail test across DST boundary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.