BUG: DTI/TDI.get_loc with mismatched-reso scalars #48815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Non-Nano
mroeschke
reviewed
Sep 27, 2022
| @@ -388,6 +388,25 @@ def test_take_fill_value_with_timezone(self): | |||
|
|
|||
|
|
|||
| class TestGetLoc: | |||
| def test_get_loc_key_unit_mismatch(self): | |||
There was a problem hiding this comment.
Side-related. Should this work when the key is tz-aware and idx is tz-naive (and vise versa)?
There was a problem hiding this comment.
ATM it works with mismatched aware/naive, but that is deprecated.
mroeschke
approved these changes
Sep 27, 2022
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* BUG: DTI/TDI.get_loc with mismatched-reso scalars * mypy fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.