Skip to content

STYLE,BUG: autotyping hook fails if run on no files #48814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 28, 2022

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Sep 27, 2022
@twoertwein twoertwein added this to the 2.0 milestone Sep 28, 2022
@twoertwein twoertwein merged commit 07023aa into pandas-dev:main Sep 28, 2022
@twoertwein
Copy link
Member

Thanks @MarcoGorelli !

@MarcoGorelli
Copy link
Member Author

MarcoGorelli commented Sep 28, 2022

should probably backport to avoid break people's contribution flow in 1.5.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 28, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 07023aa0c3bdae40e38567789ae96a2a1727106e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #48814: STYLE,BUG: autotyping hook fails if run on no files'
  1. Push to a named branch:
git push YOURFORK 1.5.x:auto-backport-of-pr-48814-on-1.5.x
  1. Create a PR against branch 1.5.x, I would have named this PR:

"Backport PR #48814 on branch 1.5.x (STYLE,BUG: autotyping hook fails if run on no files)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@MarcoGorelli
Copy link
Member Author

@meeseeksdev backport 1.5.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 28, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 07023aa0c3bdae40e38567789ae96a2a1727106e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #48814: STYLE,BUG: autotyping hook fails if run on no files'
  1. Push to a named branch:
git push YOURFORK 1.5.x:auto-backport-of-pr-48814-on-1.5.x
  1. Create a PR against branch 1.5.x, I would have named this PR:

"Backport PR #48814 on branch 1.5.x (STYLE,BUG: autotyping hook fails if run on no files)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

MarcoGorelli added a commit to MarcoGorelli/pandas that referenced this pull request Sep 28, 2022
@MarcoGorelli
Copy link
Member Author

nevermind, 1.5.x never had autotyping to begin with, no need to backport

noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
* add run_autotyping script

* simplify

* exit 0 if no paths

Co-authored-by: MarcoGorelli <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STYLE,BUG: autotyping hook fails if run on no files
2 participants